[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Adding empty files: change to svn_fs_make_file and documentation for the delta editor?

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: 2007-06-20 15:56:37 CEST

Ben Collins-Sussman wrote:
> I agree with Karl, in that an editor drive of "open_file();
> close_file()" is ambiguous, and that the editor implementation
> shouldn't make any assumptions about a file being created or changed.
> It should treat this sequence as a no-op.

Yep, +1. Besides, the file might have been opened only so that its
properties could be tweaked (open_file, change_file_prop, close_file), and
we certainly wouldn't want to claim textual mods in that scenario.

But of course, that's not what David and I were talking about. :-)

> But I also agree with David, that an editor drive of "add_file();
> close_file()" should create an empty file.

*This* is what we were talking about.

But I don't quite understand the compatibility worries David is talking
about. Or, I should say, I don't see how documenting a brand new constraint
(which we now know some folks are violating) is any less of a compatibility
problem than changing the code to do automatically what those same
folks-in-violation assumed the code did (and all without affecting the
folks-not-in-violation at all).

C. Michael Pilato <cmpilato@collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand

Received on Wed Jun 20 15:56:41 2007

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.