Hi Sage,
When you add new features to the Python bindings, can you also write
some short documentation explaining how it works? Here's an example:
def set_notify_func(self, notify_func):
"""Setup a callback so that you can be notified when paths are
affected by WC operations. When paths are affected, we will
call the function with an svn_wc_notify_t object.
For details on the contents of an svn_wc_notify_t object,
see the documentation for svn_wc_notify_t."""
I cleaned up the "notify func" part of your patch by adding some
documentation and cleaning up the parameter list for the callback
function. I committed this part of your patch in r25462.
Cheers,
David
On 6/18/07, Sage La Torra <sagelt@gmail.com> wrote:
> This patch adds callback registration to the WC python ctypes class.
> WC initialization is expanded to accept notification, log, progress
> and cancellation callbacks. If no callbacks are given, nothing is
> changed. In addition, a set method is added for each callback.
>
> [[[
> Add callback functionality to the WC class.
>
> * csvn/wc.py
> (WC.__init__): Add parameters for callback functions. No callbacks set
> by default.
> (WC.set_notify_callback, WC.set_log_callback, WC.set_cancel_func,
> WC.set_progress_func): New functions to set callback functions used
> during WC operations.
> ]]]
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jun 20 07:59:19 2007