Adding empty files: change to svn_fs_make_file and documentation for the delta editor?

On 6/19/07, C. Michael Pilato <cmpilato@collab.net> wrote:
> > [[[
> > The DAV-based RA commit editors have always assumed that
> > apply_textdelta will be called on all copied files, even empty ones,
> > and the client commit driver has always done so; document this
> > as an explicit requirement for driving a delta editor.
> >
> >
> > * subversion/include/svn_delta.h
> > (add_file): Explicitly state that you need to call apply_textdelta
> > for new uncopied files.
> > ]]]
>
> This seems like a really random thing to require. It would be much nicer to
> editor drivers for us to change those two editors to, open getting a
> close_file() with no intermediate apply_textdelta(), perform the empty
> apply_textdelta() behavior on the caller's behalf.

That was my first thought too. On the other hand, though, one of them
requires making code changes and thinking about backwards
compatibility issues, and the other one just requires documenting what
is already the status quo for all code in Subversion itself...

--dave

--
David Glasser | glasser_at_mit.edu | http://www.davidglasser.net/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org