On 6/18/07, David Glasser <glasser@mit.edu> wrote:
> On 6/13/07, David Glasser <glasser@mit.edu> wrote:
> > > * It only checks the [global] section, not the host-specific
> > > sections. This is probably not acceptable (if we want to not have
> > > host-specific preferences, then the pref should be in the main
> > > config file, not the servers file). All the code to choose
> > > sections is in libsvn_ra_dav, though.
> >
> > Somebody (I don't have time right now) really should do this before 1.5.
>
> Oh, ugh. The code that gets the host which is used to pick the group
> in ~/.subversion/servers is in libsvn_ra_dav and uses ne_uri_parse
> instead of apr_uri_parse.
I think that for the purpose of our internal use, we should use apr
functions. When we're going to parse a URI for use with Neon, I think
we should use the functions provided by Neon.
> I don't know the details of these two functions; is there a chance
> that switching the libsvn_ra_dav calls from Neon to APR will parse
> bizarre URLs in a different way? Or should I just leave the calls in
> libsvn_ra_dav be and use apr_uri_parse in the RA loader and hope
> nothing is inconsistent?
Is the function used for different purposes other than retrieving the
host section from the config hash? If so, can we parse the URI twice?
It shouldn't take much extra time to do so...
bye,
Erik.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jun 18 17:10:44 2007