[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] ctypes-python-bindings branch Rough WC Class

From: David James <james_at_cs.toronto.edu>
Date: 2007-06-15 08:16:53 CEST

On 6/14/07, Sage La Torra <sagelt@gmail.com> wrote:
> This patch adds a class representing the WC to the new python
> bindings. At present, it's a somewhat rough patch, but it does include
> some basic functionality.

Hi Sage,

Nice work! I'm glad you're making progress on this.

I took a look at your patch and noticed that many of the functions
worked at a fairly low level without taking advantage of the higher
level Subversion APIs. For example, in the diff_path function, you do
a bunch of work to re-implement svn_client_diff and
svn_wc_get_pristine_copy_path. The info and revert_all functions
suffer from similar problems. You also print stuff to the screen
instead of building a data structure which Python programmers can
easily access.

Since the svn_client_* functions usually do what we want, why don't we
just use those functions instead? I updated a couple of the functions
in your patch to use the svn_client_* functions and committed it in

Could you finish off the class, and update the 'WC' class to support
all of the WC-related functionality from the client library? Try to
submit small patches at a time so that I can review them and make sure
you're on the right track. Perhaps you can start by implementing the
client notification callback (i.e. client_ctx_t.notify_func2), so that
users can be made aware of which files were affected by their WC



To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jun 15 08:17:02 2007

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.