Daniel Rall wrote:
> On Wed, 13 Jun 2007, Blair Zajac wrote:
>
>> I'm writing some code to rename FSFS transactions if the filesystem is
>> FSFS and I was surprised to see that there's no API call given a
>> svn_fs_t to do this, I have to use svn_fs_type() which takes a path to
>> the filesystem. I'd rather not do more IO if I already have an svn_fs_t.
>
> Would this be a moot point if FSFS had unique transaction names?
Yes, for my current project.
>> Is there any reason not to save the filesystem type in svn_fs_t and
>> add a call to get it? Would this break binary compatibility? Is
>> there a good reason not to do this? Where would be the best place
>> to make this change?
>
> 'struct svn_fs_t' in subversion/libsvn_fs/fs-loader.h is an opaque
> data structure which should really only be allocated by svn_fs_new()
> (publicly deprecated, but used internally), svn_fs_open(), or
> svn_fs_create().
>
> Adding a new 'type' field to the structure's definition to cache the
> FS type will speed up any repeated calls to the svn_fs_type() API;
> sounds fine to me. The majority of the memory used by this would
> likely be memory sticking around uncleared in a pool anyhow.
What about 1.4.x clients using 1.5.x shared libraries? This shouldn't
be a problem?
Blair
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Jun 14 01:49:56 2007