Re: [PATCH] Build both serf and dav

I committed this patch (plus some changes to INSTALL and
libsvn_ra_serf/README) in r25384. People should start building their
trunk builds with both dav and serf! Somebody should add Makefile
targets that set http-library before running the test suite!

On 6/12/07, David Glasser <glasser@mit.edu> wrote:
> On 6/11/07, Daniel Rall <dlr@collab.net> wrote:
> > Looking at it another way, it's not a whole lot different than adding
> > a new parameter to a rev'd API, and hard-coding a default value for
> > the older incarnation of the API. So long as we document the
> > behavior, I'd say we're okay.
>
> OK. Should it be documented in the source, or actually in the default
> servers file?

I documented this in a ### comment at the top of the RA loader where
it discusses the dav/serf issue in general.

> Anyway, here is a preliminary patch to support building both ra_dav
> and ra_serf and choosing which one in the servers file:
>
> Some issues:
>
> * The logic is hardcoded around assuming that the only conflicts are
> ra_dav and ra_serf. I think that's fine for now.

I'm comfortable with this.

> * It only checks the [global] section, not the host-specific
> sections. This is probably not acceptable (if we want to not have
> host-specific preferences, then the pref should be in the main
> config file, not the servers file). All the code to choose
> sections is in libsvn_ra_dav, though.

Somebody (I don't have time right now) really should do this before 1.5.

> * The error thrown if the http-library is unknown is in the
> SVN_ERR_RA_DAV namespace. It's not entirely inappropriate though.

I'm comfortable with this.

> * The http-library value is validated on any use of any RA library,
> even a non-http[s] one. I think that's OK though; nobody is going
> to see that error unless they *just* tweaked the value.

I'm comfortable with this.

> * The fact that http-library is ignored by svn_ra_get_ra_library is
> not documented anywhere.

See above.

--dave

-- 
David Glasser | glasser_at_mit.edu | http://www.davidglasser.net/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org