Re: svn commit: r25357 - in trunk/subversion/tests/cmdline: . svntest

Hi Dan,

> This should be written in a more active voice:
>
> "svntest: Allow Skip condition to be a lambda function."
>
>
Fixed.
> I'd rather see this API written using non-negative logic (case in
> point, that phrasing was more difficult to understand that needed to
> be):
>
> is_posix_os()
>
> ...
>
I originally thought on the same lines. But I could not pass a negating
expression as a lambda function.

>> --- trunk/subversion/tests/cmdline/prop_tests.py (original)
>> +++ trunk/subversion/tests/cmdline/prop_tests.py Mon Jun 11 05:05:31 2007
>> @@ -28,6 +28,8 @@
>> XFail = svntest.testcase.XFail
>> Item = svntest.wc.StateItem
>>
>> +def is_non_posix_and_non_windows_os():
>>
>
> A doc string stating that this is used as a lambda function in
> test_list might be useful here.
>
>
Fixed in r25372.

Thanks for the review.

With regards
Kamesh Jayachandran

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jun 12 11:57:04 2007