[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: SVN : Re: [PATCH] cleanup fails on missing .svn/tmp

From: Daniel Rall <dlr_at_collab.net>
Date: 2007-06-08 00:50:56 CEST

On Thu, 24 May 2007, Olivier Vit wrote:

> Hi Daniel,
> (sorry but I couldn't find the way to reply to the thread on list)
> My question is about http://svn.haxx.se/dev/archive-2007-02/0084.shtml
> The conclusion of the discussion seems to say that everybody agreed for
> the fix, but I don't see it in the latest changelog
> http://svn.collab.net/repos/svn/trunk/CHANGES
> Since I encounter this problem, I would like to know if it has been
> committed or not, to be able to get a fix or report a side effect :-)

Olivier, in the future, please direct this type of question to
Subversion's users or dev mailing list. Thanks!

To answer your question, Peter Lundblad applied a version of Henner
Zeller's patch earlier this year:

r23370 | lundblad | 2007-02-08 01:13:39 -0800 (Thu, 08 Feb 2007) | 25 lines

Make 'svn cleanup' not fail on a missing .svn/tmp directory. It is
removed and rebuilt anyway so failing if it does not exist is

Patch by: Henner Zeller <h.zeller@acm.org>

* subversion/include/svn_io.h
  (svn_io_remove_dir2): New function. Add ignore_enoent flag.
  (svn_io_remove_dir): Deprecate. All callers updated to use

* subversion/libsvn_subr/io.c
  (svn_io_remove_dir2): Copy from svn_io_remove_dir, adding ignore_enoent
  (svn_io_remove_dir): Wrap svn_io_remove_dir2.

* subversion/libsvn_wc/adm_files.c (svn_wc__adm_cleanup_tmp_area): Don't
  fail if the tmp directory doesn't exist.

* subversion/tests/cmdline/basic_tests.py
  (basic_cleanup): Add regression: missing tmp-dir in cleanup.

* subversion/tests/cmdline/svntest/actions.py
  (remove_admin_tmp_dir): New function.


  • application/pgp-signature attachment: stored
Received on Fri Jun 8 00:51:10 2007

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.