Thanks Bhuvan.
> Index: subversion/include/private/svn_fs_util.h
> ===================================================================
> --- subversion/include/private/svn_fs_util.h (revision 25291)
> +++ subversion/include/private/svn_fs_util.h (working copy)
> @@ -20,6 +20,7 @@
> #ifndef SVN_FS_UTIL_H
> #define SVN_FS_UTIL_H
>
> +#include "svn_private_config.h"
> #ifdef __cplusplus
> extern "C" {
> #endif /* __cplusplus */
> @@ -39,35 +40,66 @@
> error if this is not the case. */
> svn_error_t *svn_fs__check_fs(svn_fs_t *fs);
>
> -/* SVN_ERR_FS_NOT_MUTABLE: the caller attempted to change a node
> - outside of a transaction. */
> -svn_error_t *svn_fs__err_not_mutable(svn_fs_t *fs, svn_revnum_t rev,
> - const char *path);
> +/* SVN_FS__ERR_NOT_MUTABLE: attempted to change a node outside of a
> + transaction. F is of type "svn_fs_t *", R is of type
> + "svn_rev_num_t *", P is of type "const char *". */
>
Can you retain original namings like 'fs', 'rev', 'path' instead of 'f',
'r' and 'p'.? Same with other macros too.
>
> -/* SVN_ERR_FS_NO_USER: FS does not have a user associated with it. */
> -svn_error_t *svn_fs__err_no_user(svn_fs_t *fs);
>
Explain type of 'fs' like you did for other macros.
> -/* SVN_ERR_FS_LOCK_OWNER_MISMATCH: trying to use a lock whose LOCK_OWNER
> - doesn't match the USERNAME associated with FS. */
> -svn_error_t *svn_fs__err_lock_owner_mismatch(svn_fs_t *fs,
> - const char *username,
> - const char *lock_owner);
> +/* SVN_FS__ERR_LOCK_OWNER_MISMATCH: trying to use a lock whose
> + LOCK_OWNER doesn't match the USERNAME associated with FS.
> + F is of type "svn fs_t *", U is of type "const char *",
> + O is of type "const char *". */
>
Use the original function argument names. Here you have 'u', but doc
says 'USERNAME'.
> +#define SVN_FS__ERR_LOCK_OWNER_MISMATCH(f, u, o) \
> + svn_error_createf \
> + (SVN_ERR_FS_LOCK_OWNER_MISMATCH, 0, \
>
>
With regards
Kamesh Jayachandran
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Jun 7 15:07:26 2007