Re: svn commit: r25292 - trunk/subversion/tests/cmdline
On Tue, Jun 05, 2007 at 06:20:16PM +0530, Kamesh Jayachandran wrote:
> > ... does this actually work? Skip() takes a conditional (evaluated
> > at parse time), while XFail() takes a lambda (evaluated immediately
> > prior to test execution).
> > That discrepancy is annoying, and I suspect that is_ra_type_dav() may
> > actually not work (i.e. always returns false) at the point that this
> > list is evaluated (because argument parsing doesn't happen until later),
> > and so whereas we'd never Skip the test before, we now always skip it.
> Just realised it after the commit. Even though I kept running tests on
> svnserve and dav often to fix 'authz_svnserve_anon_access_read' test failure
> over a unclean WC (due to earlier test runs). I missed this always skipping
> problem, my mistake. Working on it.
No problem - I've lost time due to these predicates returning the wrong
result in the past too, so I've just committed (r25296) an assertion
that will now fire if we call them before they're ready.
If you are able to change Skip() and XFail() so that they can both accept
either a boolean or lambda, that would be great.
Received on Tue Jun 5 16:58:32 2007
- application/pgp-signature attachment: stored
This is an archived mail posted to the Subversion Dev