[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] making depth upgrades work (sparse-directories), v2

From: Vlad Georgescu <vgeorgescu_at_gmail.com>
Date: 2007-06-04 23:33:45 CEST

Karl Fogel wrote:
> But IMHO, it would still be better, in principle, to not toss away the
> information of whether a depth was explicitly requested. Right now,
> based on the doc strings, when someone sees that 'depth' parameter in
> adm_crawler.c, they will assume it represents the depth the user
> actually requested -- yet it might not.
> So either we should change the doc strings, or change the recursion
> logic to handle svn_depth_unknown like svn_depth_infinity. I prefer
> the latter, because it would maintain the requested-depth information
> in the most intuitive way, even though it would mean adding an extra
> clause to a few conditionals.
> However, I'm not asking you to make this change. If you commit your
> patch, I'll be happy to follow up right away with the above-described
> change.

Ah, no big deal. I made the necessary changes so that svn_depth_unknown
is propagated to report_revisions_and_depths (and handled correctly),
and committed the patch in r25286.

Thanks for the review,

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jun 4 23:34:05 2007

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.