Hello,
As per the mailing list thread [1], I've converted all error related
functions in libsvn-fs-util library as macros, which allows them to
return errors with useful line number in them. Please find attached a
patch for review.
[1]
http://subversion.tigris.org/servlets/BrowseList?list=dev&by=thread&from=571463
[[
Convert the error functions in libsvn-fs-util library as macros, so it
will return errors with more useful line number in them.
* subversion/libsvn_fs_util/fs-util.c
(svn_fs__err_not_mutable, svn_fs__err_not_directory,
svn_fs__err_not_file, svn_fs__err_no_such_lock,
svn_fs__err_lock_expired, svn_fs__err_no_user,
svn_fs__err_lock_owner_mismatch, svn_fs__err_path_already_locked):
Remove definition for error functions. They are replaced with a new
macro definition.
* subversion/include/private/svn_fs_util.h
(svn_fs__err_not_mutable, svn_fs__err_not_directory,
svn_fs__err_not_file, svn_fs__err_no_such_lock,
svn_fs__err_lock_expired, svn_fs__err_no_user,
svn_fs__err_lock_owner_mismatch, svn_fs__err_path_already_locked):
Remove declaration for error functions and define new macro which
allows them to return error with more useful line number in them.
Include svn_private_config.h header file.
* subversion/libsvn_fs_base/tree.c
* subversion/libsvn_fs_base/bdb/locks-table.c
* subversion/libsvn_fs_base/bdb/lock-tokens-table.c
* subversion/libsvn_fs_base/lock.c
* subversion/libsvn_fs_fs/lock.c
* subversion/libsvn_fs_fs/tree.c
Use new macros.
Suggested by: dlr,
malcolmr
]]
--
Regards,
Bhuvaneswaran
Received on Mon Jun 4 12:17:26 2007