Re: [PATCH] bash_completion: propose file names for few commands

Dear Krzysiek,

> Attached patch has SVN_EXT_NON_RECURSIVE - if it's set to non empty string
> recursion will be disabled.

ISTM that it is not only the recursion but the whole svn calls which
should be disabled. That would/could make two options... Moreover, I would
prefer the option to be "disabled" by default.

Maybe a positive SVN_COMPLETION_OPTIONS which would contain values such
as... something clear and explicit to be devised... to ENABLE costly
features for those who dare. As there are various suggestions for costly
extensions around, having such a framework might make sense.

>> (3) I do not like to have "awk" for such very simple stuff.
>> use cut instead? Or emulate grep/awk in shell (one loop) ?
>
> awk -> cut done

Hmm.

I noticed that you also put sed, so we have a sed+grep+cut dependency,
possibly the 3 of them together, that makes 4 fork/exec on a <tab>.
Possibly one would be enough, e.g. sed can do it all. Or a shell loop.

Also about "if [[ ... ]] && [[ ... ]]", one can have "&&" directly within
the [[ ... ]] test in bash.

About revert: more things can be reverted, including a D or an A, not just
M or !. If you replace the file completion list, you must get it right.

About log: basically one can ask about the log of any file, added value of
having a "svn ls" is quite reduced here?

About del: I cannot see the point of the 'sed -e 1d'. If it is to skip the
current directory, it is just wrong as externals are displayed before it.

I'm unsure also about what happends under different locales (e.g. Chinese
or the like) when handling the output of "svn something". Might be just
okay, but I don't know.

-- 
Fabien.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org