Malcolm Rowe wrote:
> On Fri, Jun 01, 2007 at 12:52:43PM -0500, Hyrum K. Wright wrote:
>> log
>> params: ( ( target-path:string ... ) [ start-rev:number ]
>> [ end-rev:number ] changed-paths:bool strict-node:bool
>> ? limit:number ? include-merged-revisions:bool )
>>
>> Doesn't the '?' indicate that the limit and include-merged-revisions are
>> optional?
>
> Not quite - it indicates that the tuple can stop at that point. New
> clients can't send a value for include-merged-revisions without also
> filling in limit. ('start-rev' is an example of something that's truly optional).
>
> So my question was: how do I sent a log query without a limit, but with
> include-merged-revisions? I assume I set the limit to zero, or
> similar, but the protocol document should document that.
>
>> include-merged-revisions is optional because pre-1.5 won't
>> send it. I guess I'm just failing to see the difference between a
>> earlier client not sending the parameter, and the parameter being
>> optional in the protocol.
>>
>
> If the parameter's optional, it can be omitted from any request - limit
> can only be omitted if you also omit include-merged-revisions.
Thanks for the clarification. I've updated the comment and protocol
documentation in r25257.
-Hyrum
Received on Fri Jun 1 20:23:43 2007