Discussion of the fix for avoiding updating merge info when merging from another repos (issue #2788/r25233)

On Fri, 01 Jun 2007, Paul Burba wrote:

> > -----Original Message-----
> > From: Daniel Rall [mailto:dlr@collab.net]
...
> > Along the way, I realized that if
> > record_only is set, that we don't actually care about the
> > value of same_repos.
>
> I don't think I follow, are you saying a merge without --record-only
> from a different repos won't update mergeinfo, but with --record-only it
> will?

You didn't follow because what I wrote didn't make any sense.
Substitute "--dry-run" for "--record-only" (as I intended to write),
and it does.

> > It would be more efficient to either a)
> > not calculate same_repos when record_only is true, or b)
> > delay calculation until same_repos is actually needed
> > (sticking any necessary contextual data in the baton).
> > Is this minor efficiency gain worth the additional complexity
> > from (a) or (b)? I lean towards "no", but thought I'd
> > mention it anyways..
...