[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r25240 - trunk/subversion/include

From: Daniel Rall <dlr_at_collab.net>
Date: 2007-05-31 22:31:39 CEST

On Thu, 31 May 2007, Blair Zajac wrote:

> Hyrum K. Wright wrote:
> >blair@tigris.org wrote:
> >>Author: blair
> >>Date: Thu May 31 11:18:50 2007
> >>New Revision: 25240
> >>
> >>Log:
> >>* subversion/include/svn_repos.h:
> >> Style fix, associate remove the space between the * and the function
> >> name to match the rest of the file.
> >>
> >>
> >>Modified:
> >> trunk/subversion/include/svn_repos.h
> >>
> >>Modified: trunk/subversion/include/svn_repos.h
> >>URL:
> >>http://svn.collab.net/viewvc/svn/trunk/subversion/include/svn_repos.h?pathrev=25240&r1=25239&r2=25240
> >>==============================================================================
> >>--- trunk/subversion/include/svn_repos.h (original)
> >>+++ trunk/subversion/include/svn_repos.h Thu May 31 11:18:50 2007
> >>@@ -228,10 +228,10 @@
> >> * means deleting copied, unused logfiles for a Berkeley DB source
> >> * repository.
> >> */
> >>-svn_error_t * svn_repos_hotcopy(const char *src_path,
> >>- const char *dst_path,
> >>- svn_boolean_t clean_logs,
> >>- apr_pool_t *pool);
> >>+svn_error_t *svn_repos_hotcopy(const char *src_path,
> >>+ const char *dst_path,
> >>+ svn_boolean_t clean_logs,
> >>+ apr_pool_t *pool);
> >
> >Actually, I thought our style would dictate:
> >svn_error_t *
> >svn_repos_hotcopy(const char *src_path,
> > const char *dst_path,
> > svn_boolean_t clean_logs,
> > apr_pool_t *pool);
> >
> >But, I don't think that's followed very closely in some places.
> >
> >-Hyrum
>
> Checking the hacking document, yes, that's correct. Before I read
> checked it, I was under the impression that if the function name and its
> arguments extend past 80 characters, then you wrap to the next line,
> otherwise, you keep on the same line.

I do prefer them on separate lines.

  • application/pgp-signature attachment: stored
Received on Thu May 31 22:34:51 2007

This is an archived mail posted to the Subversion Dev mailing list.