[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Re: svn commit: r25204 - trunk/subversion/tests/cmdline

From: David Glasser <glasser_at_mit.edu>
Date: 2007-05-31 17:16:05 CEST

On 5/30/07, Paul Burba <pburba@collab.net> wrote:
> > -----Original Message-----
> > From: Malcolm Rowe [mailto:malcolm-svn-dev@farside.org.uk]
> > chdir() calls should be inside a try/finally block so that an
> > exception inside won't break the rest of the tests (due to
> > failure to reset the cwd).

> I made this one change (r25225) mentioned by Malcolm as I added a new
> merge test today. Without this change my test, which comes after
> copy_src_detection_bug_if_target_has_many_ancestors_in_same_commit() in
> the test_list, fails.

Hmm. Could we just put cwd save/reset into the test driver, and
delete all of the repetitive try/finally blocks in the tests?

--dave

-- 
David Glasser | glasser_at_mit.edu | http://www.davidglasser.net/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu May 31 17:16:52 2007

This is an archived mail posted to the Subversion Dev mailing list.