[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] don't tempt users to add to tigris.org's referer logs

From: Karl Fogel <kfogel_at_red-bean.com>
Date: 2007-05-23 07:47:10 CEST

"Erik Kline" <ek@google.com> writes:
> Not sure if people mind or if this is just a "shrug" but I figured
> perhaps a few corporate installations would appreciate not tempting
> users to click on the link and unwittingly contribute referer urls to
> the subversion.tigris.org logs.
>
> [[[
> * subversion/mod_dav_svn/repos.c
> (deliver): If generating html output, don't tempt users to add
> their (possibly internal, corporate) referer links to
> subversion.tigris.org's logs. The anchor tag is removed and the
> href attribute contents are integrated into the plain text.
> ]]]

I'm not sure I get the motivation. This is showing up in HTML output,
right? Isn't it standard for a "Powered by Foo" tag to link back to
the Foo project? Why wouldn't we want to do that here?

How is "contribute referer urls to the subversion.tigris.org logs"
different from "browse to subversion.tigris.org", and assuming they
are equivalent, why would we not encourage the latter?

-Karl

> Index: subversion/mod_dav_svn/repos.c
> ===================================================================
> --- subversion/mod_dav_svn/repos.c (revision 25113)
> +++ subversion/mod_dav_svn/repos.c (working copy)
> @@ -2789,7 +2789,7 @@
> if (gen_html)
> ap_fputs(output, bb,
> " </ul>\n <hr noshade><em>Powered by "
> - "<a href=\"http://subversion.tigris.org/\">Subversion</a> "
> + "Subversion (http://subversion.tigris.org) "
> "version " SVN_VERSION "."
> "</em>\n</body></html>");
> else
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed May 23 07:47:23 2007

This is an archived mail posted to the Subversion Dev mailing list.