[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Remove APR_ICONV dependency on Windows

From: Mark Phippard <markphip_at_gmail.com>
Date: 2007-05-16 22:10:07 CEST

On 5/16/07, Stefan Küng <tortoisesvn@gmail.com> wrote:
> Mark Phippard wrote:
> > I have been running into some weird ICONV problems with Subclipse on
> > Windows. The problem is that we have never been able to deliver the
> > ICONV *.so files with Subclipse. So either the user has installed the
> > command line and set APR_ICONV_PATH and they get the functionality, or
> > they have not and they do not.
> >
> > Anyway, I am currently building trunk with APR 1.2 and ICONV 1.1. If
> > Subclipse is run on a system with environment variable set and pointed
> > at 0.9.7 files, then the JVM crashes.
> >
> > This reminded me of this thread from 2005:
> >
> > http://subversion.tigris.org/servlets/BrowseList?list=dev&by=thread&from=375124
> >
> >
> > Stefen King submitted a patch and went through the review process on
> > code to remove the dependency and use the Win32 conversion functions.
> > I did not see any -1's and he re-submitted the patch several times.
> > Any chance we could revive this and get it into Subversion trunk?
> >
> > He already uses it with TortoiseSVN. I could manually patch the build
> > I do for Subclipse but I would rather not since when I do a release I
> > typically use the DLL's that get posted to Subversion site.
>
> FYI: the patched file (utf.c) which I now use for TortoiseSVN can be
> found here:
> http://tortoisesvn.tigris.org/svn/tortoisesvn/trunk/ext/build/utf.c
>
> Note: it does not work if conversions are needed from/to another locale
> than the local one. But since UI clients usually only convert to the
> current locale from/to utf8, that's not really an issue.

I do not believe Subversion does any other kind of conversion either.

Stefan, what happened last time? Did you just get tired of the back
and forth and decide it was easy enough to handle in your build
system? It seemed like you addressed all the comments though, why did
this not get applied?

I am not a C programmer, but looking at the code, it looked like you
conditioned it based on something you are DEFINE in your own buld
system. Could we just make it always do this when building on WIN32?

-- 
Thanks
Mark Phippard
http://markphip.blogspot.com/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed May 16 22:10:30 2007

This is an archived mail posted to the Subversion Dev mailing list.