[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH]Fix Segfault while detecting the implicit merge source

From: Kamesh Jayachandran <kamesh_at_collab.net>
Date: 2007-05-15 19:38:57 CEST

>> ctx, pool));
>> @@ -241,7 +242,7 @@
>> {
>> const char *path;
>> apr_hash_this(hi, (void *) &path, NULL, NULL);
>> - if (strcmp(path, copyfrom_path) != 0)
>> + if (copyfrom_path && strcmp(path, copyfrom_path) != 0)
>>
>
> Shouldn't this be?:
>
> if (copyfrom_path == NULL || strcmp(path, copyfrom_path) != 0)
>
>
No. It segfaults in strcmp when copyfrom_path is NULL.

With regards
Kamesh Jayachandran

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue May 15 19:39:07 2007

This is an archived mail posted to the Subversion Dev mailing list.