[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [patch] ruby bindings tracking the recurse=>depth changes in svn_client_proplist3

From: Joe Swatosh <joe.swatosh_at_gmail.com>
Date: 2007-05-15 08:23:06 CEST

Hi

On 5/14/07, Kouhei Sutou <kou@cozmixng.org> wrote:
> Hi,
>
> 2007/5/15, Joe Swatosh <joe.swatosh@gmail.com>:
>
> > [[[
> > Follow on to r25007 which added depth support to svn_client_proplist3.
> >
> > * subversion/bindings/swig/ruby/svn/client.rb
> > (Svn::Client::Context#proplist) changed argument name and default to
> > reflect the use of depth instead of recurse in the core API.
> > ]]]
> >
> > Index: subversion/bindings/swig/ruby/svn/client.rb
> > ===================================================================
> > --- subversion/bindings/swig/ruby/svn/client.rb (revision 25014)
> > +++ subversion/bindings/swig/ruby/svn/client.rb (working copy)
> > @@ -215,7 +215,7 @@
> > # Returns list of properties attached to +target+ as an Array of
> > # Svn::Client::PropListItem.
> > # Paths and URIs are available as +target+.
> > - def proplist(target, rev=nil, peg_rev=nil, recurse=true, &block)
> > + def proplist(target, rev=nil, peg_rev=nil,
> > depth=Core::DEPTH_INFINITY, &block)
>
> We can use depth=nil for the same propose. (see
> svn_swig_rb_to_depth()) Could you use nil instead of
> Svn::Core::DEPTH_INFINITY and commit this patch?
>
> > rev ||= "HEAD"
> > peg_rev ||= rev
> > items = []
> > @@ -223,7 +223,7 @@
> > items << PropListItem.new(path, prop_hash)
> > block.call(path, prop_hash) if block
> > end
> > - Client.proplist3(target, rev, peg_rev, recurse, receiver, self)
> > + Client.proplist3(target, rev, peg_rev, depth, receiver, self)
> > items
> > end
> > alias prop_list proplist
>
>

Committed in r25019 with your modification. I figure we can change it
later if nil is the wrong default.

--
Joe
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue May 15 08:23:23 2007

This is an archived mail posted to the Subversion Dev mailing list.