[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] 1/5 svnmerge: clearly differentiate urls, directories, and repo-relative paths

From: David James <james_at_cs.toronto.edu>
Date: 2007-05-11 23:23:05 CEST

On 5/11/07, dustin@v.igoro.us <dustin@v.igoro.us> wrote:
> On Thu, May 10, 2007 at 03:05:30AM -0500, dustin@v.igoro.us wrote:
> > This is the first of five patches, the last of which implements
> > cross-repository merging even when repo-relative paths are identical
>
> Any feedback on this? I realize it's basically changing comments, but
> the good stuff is in parts 2-5 ;)

Hi Dustin,

Personally, I'm not a big fan of the term "locid", but other than
that, your patch looks great. How about "path_id"? In the comments, we
can explain that a path_id is a UUID/path pair. Further, in
user-facing error messages where we talk about path_ids, we should
probably call them UUID/path pairs, so that users will understand what
we are talking about without needing to read the source.

Cheers,

David

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri May 11 23:23:14 2007

This is an archived mail posted to the Subversion Dev mailing list.