[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH]: svnmerge between multiple repositories, same repo path

From: Hyrum K. Wright <hyrum_wright_at_mail.utexas.edu>
Date: 2007-05-08 16:20:12 CEST

dustin@v.igoro.us wrote:
> On Tue, May 01, 2007 at 01:02:19PM -0500, dustin@v.igoro.us wrote:
>> Pursuant to discussion on the svnmerge mailing list, I wrote up some
>> patches to allow svnmerge to merge between multiple repositories, where
>> the repository path is the same in each.
> Sorry to self-reply here, but does anyone want to second this patch,
> before I put it on the tracker? Alternately, does anyone think it's a
> terrible idea, and want to eviscerate me for even conceiving of it?

Thanks for following up on this. After looking at your previous mail,
I've not reviewed the patches, but I do have a couple of suggestions.
While you did include summaries of your patches, they don't follow our
log message guidelines[1]. By submitting your patches with appropriate
messages, they are much more likely to get reviewed.

The patch submission guidelines[2] also note that "a patch submission
should contain one logical change; please don't mix N unrelated changes
in one submission -- send N separate emails instead." Sending five
patches in one mail may be a bit difficult for some people to grok.

May I suggest either grouping the patches together in logical chunks, or
submitting them serially? (Submit one, discuss, apply, repeat.) It may
take more time that way, but the reviewers are more likely to understand
what each patch is doing.

[1] http://subversion.tigris.org/hacking.html#log-messages
[2] http://subversion.tigris.org/hacking.html#patches

(I've also updated the subject to include the brackets around [PATCH] so
that it gets filtered correctly.)


Received on Tue May 8 16:20:26 2007

This is an archived mail posted to the Subversion Dev mailing list.