[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fix Python digest typemap

From: David James <james_at_cs.toronto.edu>
Date: 2007-05-07 03:55:49 CEST

On 5/4/07, Eric Gillespie <epg@pretzelnet.org> wrote:
> I'm not sure where the new test really belongs. Should i add a
> new file for high-level tests of multiple layers? This one uses
> delta, ra, and wc.

No, this is fine. Generally, you should put tests in the file which is
most affected by the change. Great work on the test!

I have a question. Why do you think that the MD5 checksums should be
passed in raw format instead of in cstring format? Your change breaks
compatibility with any code which previously used the checksum return
value, so we should have a good reason if we want to change it.

Cheers,

David

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon May 7 03:56:26 2007

This is an archived mail posted to the Subversion Dev mailing list.