[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Wrap wcprop callbacks for svn_ra_callbacks_t

From: David James <james_at_cs.toronto.edu>
Date: 2007-05-04 22:55:27 CEST

On 5/4/07, Eric Gillespie <epg@pretzelnet.org> wrote:
> "David James" <james@cs.toronto.edu> writes:
>
> > Nice work, Eric! I haven't tested your patch, but the code looks good.
>
> Thanks. I meant to note this, but forgot: This is not really
> testable yet, as the callbacks are only used by ra-dav (and i
> guess ra-serf, too). I have tested this extensively with a test
> suite for another application, over http. If i can find the
> time, i'll work on a davautocheck-swig-py target.

If it's tested and ready to go, feel free to commit. Automated tests
are nice but not a requirement if a committer can vouch for the code.

If you're going to work on new tests for the Python DAV layer, I'd
encourage you to write those tests for the ctypes python bindings,
because I think that we are going to encourage folks to migrate to the
ctypes bindings soon :)

Cheers,

David

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri May 4 22:55:45 2007

This is an archived mail posted to the Subversion Dev mailing list.