[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r24884 - trunk/subversion/svn

From: Daniel Rall <dlr_at_collab.net>
Date: 2007-05-02 18:24:34 CEST

On Wed, 02 May 2007, malcolm@tigris.org wrote:
...
> When creating svn-commit.tmp, treat the error 'read-only filesystem'
> the same as 'access denied': switch to creating the temporary file in
> the system temporary path instead.
>
> * subversion/svn/util.c
> (svn_cl__edit_externally): Add EROFS to the list of errors to check for.
...
> --- trunk/subversion/svn/util.c (original)
> +++ trunk/subversion/svn/util.c Wed May 2 05:22:25 2007
> @@ -196,7 +196,7 @@
> err = svn_io_open_unique_file2(&tmp_file, &tmpfile_name,
> prefix, ".tmp", svn_io_file_del_none, pool);
>
> - if (err && APR_STATUS_IS_EACCES(err->apr_err))
> + if (err && (APR_STATUS_IS_EACCES(err->apr_err) || err->apr_err == EROFS))
> {
> const char *temp_dir_apr;

Is EROFS defined on all operating systems? If not, we might want to
#ifdef that check.

- Dan

  • application/pgp-signature attachment: stored
Received on Wed May 2 18:24:44 2007

This is an archived mail posted to the Subversion Dev mailing list.