Re: svn commit: r24791 - in trunk/subversion/bindings/javahl: native src/org/tigris/subversion/javahl src/org/tigris/subversion/javahl/tests

On 5/1/07, Hyrum K. Wright <hyrum_wright@mail.utexas.edu> wrote:
>
> The attached patch uses a byte array instead of a String to move the
> property values from the Java layer to the C++ layer. I have a little
> misgiving about using a ClientException, but I don't see a better way to
> implement the error handling when specifying the UTF-8 encoding.

I have only loosely followed this thread and do not really understand
the C++ code enough to comment. But stepping back, we had two methods
that presumably worked and did roughly the same thing. We wanted to
apparently consolidate the C++ code to a single method. If both of
the previous methods worked correctly than what is the complication
here in terms of the encoding?

In general I am just concerned when we are taking working code and
changing it to eliminate redundancy but are not 100% sure we are not
now adding problems.

-- 
Thanks
Mark Phippard
http://markphip.blogspot.com/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org