Re: [PATCH] Make DAV activity db location configurable

On Mon, Apr 30, 2007 at 10:43:32AM -0700, Eric Gillespie wrote:
> Make the location of mod_dav_svn's activity database configurable with a
> new SVNActivitiesDB configuration directive. If set, use it directly as
> the activity db for SVNPath repositories. For SVNParentPath repositories,
> use it to contain activity db directories named after the repository
> basename. If this directive is not specified, use "dav/activities.d" at
> the top of the repository.

It's a pity that we can't define the default behaviour of
SVNActivitiesDB in terms of a valid value, but I guess that's okay. Do
we need to document this new directive somewhere?

+1, looks good - you just need to update some comments to reflect the
change to create the dav directory if --pre-1.4-compatible.

One in the log message:

> * subversion/libsvn_repos/repos.c
> (create_svn_repos_t): Don't fill in dav_path.
> (create_repos_structure): Take fs_config argument and create the
> "dav" path (SVN_REPOS__DAV_DIR) only if it has the
> SVN_FS_CONFIG_PRE_1_5_COMPATIBLE setting.

And one in the comments:

> ]]]
>
> Index: subversion/libsvn_repos/repos.c
> ===================================================================
> - /* Create the DAV sandbox directory. */
> - SVN_ERR_W(create_repos_dir(repos->dav_path, pool),
> - _("Creating DAV sandbox dir"));
> + /* Create the DAV sandbox directory if pre-1.5-compatible. */

Or if pre-1.4-compatible. Or perhaps more generally, "if a repository
compatible with a version before 1.5 was requested".

> + if (fs_config
> + && (apr_hash_get(fs_config, SVN_FS_CONFIG_PRE_1_4_COMPATIBLE,
> + APR_HASH_KEY_STRING)
> + || apr_hash_get(fs_config, SVN_FS_CONFIG_PRE_1_5_COMPATIBLE,
> + APR_HASH_KEY_STRING)))

Regards,
Malcolm