[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Should --pre-1.4-compatible imply --pre-1.5-compatible?

From: Malcolm Rowe <malcolm-svn-dev_at_farside.org.uk>
Date: 2007-04-28 11:51:55 CEST

On Fri, Apr 27, 2007 at 04:25:23PM -0700, Eric Gillespie wrote:
> Seems to me it should. I feel like a dope typing 'svnadmin
> create --pre-1.4-compatible --pre-1.5-compatible'. How about
> this patch? The alternative is to check both config values
> everywhere, but that seems hairy...
> [[[
> * subversion/svnadmin/main.c
> (subcommand_create): Make --pre-1.4-compatible imply --pre-1.5-compatible.
> ]]]

I thought about that, but then I decided that it would be more sensible
to make FSFS (currently the only user) do that implication while it was
checking for both values (which it needs to do anyway), so that we would
have the same behaviour from clients other than svnadmin.

[ So the code called from svn_fs_fs__create() reads something like:

  if --pre-1.4-compatible
    make format 1
  else if --pre-1.5-compatible
    make format 2
    make format 3

Perhaps we need to make the help text clearer though, if you thought
you needed both?


  • application/pgp-signature attachment: stored
Received on Sat Apr 28 11:53:05 2007

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.