[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Better contribulyzation of comments

From: Daniel Rall <dlr_at_collab.net>
Date: 2007-04-27 17:43:37 CEST

On Fri, 27 Apr 2007, Malcolm Rowe wrote:

> I've seen the recent patches to unindent '(Tweaked by me)' and the like
> in log messages so that they don't appear in the Contribulyzer, and so I
> was going to add a comment to that effect to the crediting section of
> HACKING, but then I figured that it might be smarter for the
> Contribulyzer to just ignore them anyway.
> What do people think of the following patch?
> [[[
> Make the Contribulyzer treat indented parenthetical asides as asides
> rather than names to generate a contribution summary for.
> * tools/dev/contribulyze.py
> (parenthetical_aside_re): Allow (ignored) leading whitespace.
> (graze): In continuation lines for fields, ensure that lines that
> contain whitespace followed by an open parenthesis are not consider
> a named continuation for the field.
> ]]]
> Note that I also removed the '+' quantifier from the '(\S.*)+' part of
> the in_field_re regex, as I couldn't see that it would ever do anything
> other than enforce a single match.

+1, looks good.

  • application/pgp-signature attachment: stored
Received on Fri Apr 27 17:44:20 2007

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.