[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] svn_io_remove_dir mishandles links

From: Dan Christian <dchristian_at_google.com>
Date: 2007-04-24 01:21:43 CEST

Here is an updated patch.

It turns out that readdir is telling us about links, so the extra stat
isn't needed (at least on Linux). The code was just overly
restrictive and ignoring everything that wasn't a regular file.

I've tested this in my code and "make check" is passing (as of 28 of 50).

-Dan Christian

On 4/20/07, Dan Christian <dchristian@google.com> wrote:
> svn_io_remove_dir fails to remove directory trees containing symbolic links.
> There seem to be two problems: first anything other than dirs and
> regular files were ignored (there was already a comment to this
> effect). Second, it never checked for symbolic links. A symbolic
> link to a directory would be walked like a regular directory entry
> (possibly causing things outside the tree to be deleted).
> There is no test case, because I can't find anything already testing
> svn_io_remove_dir.
> Oh, svn_walk_dir has similar problems (that was my first attempt at
> working around the problems in svn_io_remove_dir). It should be
> getting link info and handling them. I haven't worked on a patch for
> this yet.
> -Dan Christian

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Received on Tue Apr 24 01:21:56 2007

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.