Attached is an alternate fix for the hot-backup.py and read-only file
issue. I believe this is a cleaner solution since it does not use timeout
delays, and it only traverses the directory tree one time. Also, the code
that changes the file mode only runs if it is needed. Feel free to use
any part of the script. I do my work in the windows environement, so I
have not been able to test this script under Linux. If you try it under
Linux, let me know the results.
Chad
<--- last part of the modified hot-backup.py script --->
### Step 5: finally, remove all repository backups other than the last
### NUM_BACKUPS.
# Python cannot delete read-only files under Windows; this handler tries
to remove the
# the read-only protection and then delete the file.
def handler(func, path, execinfo):
# if this is called because we could not remove a file,
# then see if it READONLY...
if (func == os.remove) and not os.access(path, os.W_OK):
# if it is READONLY, change it back to NORMAL and try again...
os.chmod(path, stat.S_IWRITE)
os.remove(path)
else:
# something else must be wrong...
raise
if num_backups > 0:
regexp = re.compile("^" + repo + "-[0-9]+(-[0-9]+)?" + ext_re + "$")
directory_list = os.listdir(backup_dir)
old_list = filter(lambda x: regexp.search(x), directory_list)
old_list.sort(comparator)
del old_list[max(0,len(old_list)-num_backups):]
for item in old_list:
old_backup_item = os.path.join(backup_dir, item)
print "Removing old backup: " + old_backup_item
if os.path.isdir(old_backup_item):
# specify an error handler to process read-only files
shutil.rmtree(old_backup_item, False, handler)
else:
os.remove(old_backup_item)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Apr 23 21:53:18 2007