Re: [PATCH] Make sparse-directories checkouts/updates work with old servers

Karl Fogel wrote:
> Vlad, I think this patch is still outstanding -- were you planning to
> post another iteration? (It sounded like you were, if not let me know.)
>

I was, but there's some stuff I need to figure out first (see below).

> To answer your question:
>
>> For example, what happens (or should happen) if we do a depth=infinity
>> update on a depth=empty wc? Do we:
>>
>> a) do a depth=empty update
>> b) bring in everything that's missing into the wc, effectively making it
>> depth=infinity
>> c) update only those files and directories in the wc that have been
>> brought in explicitly
>>
>> notes/sparse-directories.txt says b), but I don't think that's what the
>> code in trunk/ currently does.
>
> I'm pretty sure (b) is correct; if trunk needs a bugfix, then trunk
> needs a bugfix, but let's not let that stand in the way of your patch.
>
> -K

Hmm, I'm not sure it's something as simple as a bugfix. Suppose we
checkout a greek tree at depth=empty, and then do a depth=infinity
update. How is the (1.5+) server supposed to know it should send A/ and
iota? All it sees is the top-level set-path with a depth of infinity,
the same as a fully complete working copy might send.

With old servers it gets more complicated. You'd probably have to call
delete-path on each file or directory that's missing, except that a
working copy doesn't actually have that information.

And, of course, whatever solution we come up with must simultaneously
work for both old and new servers, because we don't currently
distinguish between them.

-- 
Vlad
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org