[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] JavaHL list API update

From: Mark Phippard <markphip_at_gmail.com>
Date: 2007-04-21 19:22:58 CEST

On 4/20/07, Hyrum K. Wright <hyrum_wright@mail.utexas.edu> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> The following patch updates the JavaHL list implementation to use the
> most recent version of svn_client_list. The callback addition and other
> changes were straightforward, except for the implementation of the
> compatibility wrapper.
>
> There was a semantic change between svn_client_ls3() and
> svn_client_list() which accounted for in svn_client_ls3()'s
> implementation of the wrapper. I believe that I've captured the same
> changes in the MyListCallback class, but want to make sure.

In the DirEntry class you change the constructor. You have to add a
new one and leave the old one intact, else you are breaking
compatibility.

The MyListCallback looks OK. I am just trusting that you are right
about the semantic change since I have not looked at the C API. I am
a little confused about what exactly the change was though.

-- 
Thanks
Mark Phippard
http://markphip.blogspot.com/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Apr 21 19:23:19 2007

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.