[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r24680 - in trunk: notes subversion/libsvn_ra_dav

From: Karl Fogel <kfogel_at_red-bean.com>
Date: 2007-04-21 03:48:16 CEST

cmpilato@tigris.org writes:
> + COMPLICATION: the editor vtable's delete_entry() function is
> + path-kind ignorant, which means that client-side editors
> + trying to compensate for over-informative server-side editor
> + drivers don't have enough information to correctly distinguish
> + whether a deletion of an immediate child should be allowed to
> + pass thru when using svn_depth_files.

Hmm, is this really a problem?

The call to editor->delete_entry() may not say the path's kind, but
the client knows the path's kind anyway, because the client has access
to the working copy. And the client knows that the server agrees
about path's kind, since the server and client already agreed on the
tree's state. When the server sends delete_entry(P):

   - If the client doesn't even have P anywhere, then clearly the
     client can ignore the call (?)

   - If the client does have P, then it knows P's kind, and it also
     knows the requested depth (because it's the client), so it can
     figure out whether or not to ignore the call.


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Apr 21 03:48:28 2007

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.