Hyrum K. Wright wrote:
> C. Michael Pilato wrote:
>> Hyrum K. Wright wrote:
>>> While attempting a build without debugs flags earlier today, I noticed
>>> that the vanilla configure includes '-g -O2' in CFLAGS. This is kind of
>>> pointless, because of the fact that debugging with optimizations is
>>> painful at best, futile at worst. r24655 was a somewhat misguided
>>> effort to fix that problem, and quickly managed to break the
>>> buildslaves. It was reverted in r24666.
>>> So, my proposal is thus:
>>> 1) Currently configure complains if '--disable-debug' is given with
>>> '--enable-maintainer-mode' because the second implies
>>> '--enable-debug'. After some discussion on IRC, dlr proposed the
>>> I think '--enable-maintainer-mode' '--disable-debug' should define
>>> SVN_DEBUG, but turn off -g.
>>> I agree, and propose it be implemented as such.
>>> 2) Debug symbols, that is including '-g' in CFLAGS, should be off by
>>> default, and only enabled when requested by '--enable-debug' or
>>> '--enable-maintainer-mode'. We may have had this debate before, but
>>> what is the reason for a vanilla './configure' including '-g'?
>> You don't explicitly address the -O2 complaint. What's your plan?
>> (I think --enable-maintainer-mode should turn off optimizations.)
> Agreed. Especially since it implies --enable-debug, and hence -g.
I believe the attached patch implements these changes. If someone could
double-check my autoconf, I'll commit this.
Disable debug symbols by default, unless requested by '--enable-debug'
or '--enable-maintainer-mode'. Also, disable optimizations when using
Received on Thu Apr 19 22:55:46 2007