[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r24318 - in trunk: notes subversion/bindings/java/javahl/native subversion/bindings/java/javahl/src/org/tigris/subversion/javahl subversion/bindings/java/javahl/src/org/tigris/subversion/javahl/tests

From: Blair Zajac <blair_at_orcaware.com>
Date: 2007-04-18 22:42:56 CEST

Daniel Rall wrote:
> On Mon, 02 Apr 2007, Blair Zajac wrote:
>
>> Daniel Rall wrote:
>>> On Sun, 01 Apr 2007, Blair Zajac wrote:
>>>
>>>> I think this commit introduced a bunch of tabs, at least in
>>>> subversion/bindings/java/javahl/native/SVNClient.cpp.
>>> Looks like you removed the tabs -- thanks.
>>>
>>> I fixed my .emacs C++ hook to stop inserting them.
>>>
>>>> Also, the
>>>> formatting doesn't seem to be in the C style.
>>> None of C/C++ JavaHL code follows that style.
>> Yeah, I realized that after I sent this note.
>>
>> Maybe we should do a global reformat of the C++ code.
>
> I'd be okay with that.
>
>> Using XEmacs, it's pretty easy to use to svn-dev.el re-indent all the
>> code to match the style of the rest of our code.
>
> One thing about the reformatting that's been happening recently with
> the JavaHL code -- it makes it more difficult to track or port changes
> across branches. If this is going to happen, I'd like it to occur
> pre-1.5, and basically all at once. all
>
> Thanks, Dan

Done in r24640.

Blair

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Apr 18 22:43:15 2007

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.