[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] javahl using microsecond time in LogMessage

From: Blair Zajac <blair_at_orcaware.com>
Date: 2007-04-18 01:18:12 CEST

Working on a new Java Subversion project, I have a number of
repositories that by design will have revisions that do not have
monotonically increasing dates. So I'll be doing my own date to
revision search through a log history.

So I need two things, one is microseconds time since 1970 as stored in
apr_time_t and I want to do the sorting fast. Currently, the
java.util.Date's contain microsecond time since 1970, so the sorting
algorithm may not be accurate if I truncate the times. Also, if I use
new log message callback in trunk's SVNClient.logMessages(), then I can
get the timestamp and with the attached patch, not have to construct
java.util.Date's and only use the timestamp.

The current LogMessage class grows an additional field, but besides
calling the new constructor from the C++ code, will there be any
ramifications of doing this?

Is this a safe change to make? Will it break anything for older clients?

I know in C land, adding a field to a class or structure can be
problematic, but in Java, will their be an issue?

I need to add a new constructor, but I'm keeping the old one around and
populating it from the timestamp in the java.util.Date, in case anybody
calls it?


Allow the JavaHL bindings for log messages to get the original
apr_time_t value in microseconds since 00:00:00 January 1, 1970 UTC.
Currently, the java.util.Date object contains only the microseconds.

[all in subversion/bindings/javahl]

* src/org/tigris/subversion/javahl/LogMessage.java
     New private long field.
     Add an additional constructor that takes the commit time measured
       in the number of microseconds since 00:00:00 January 1, 1970
     For the original constructor, populate the timeMicros from the
       java.util.Date.getTime() method.
     Returns the commit time measured in the number of microseconds
       since 00:00:00 January 1, 1970.
     Returns the commit time measured in the number of milliseconds
       since 00:00:00 January 1, 1970.

* src/org/tigris/subversion/javahl/LogMessageCallback.java
     Instead of taking a java.util.Date() as an argument, take a long
       value with the number of milliseconds since 00:00:00 January 1,
       1970. Users of the callback can always construct a new
       java.util.Date if they need it.

* native/LogMessageCallback.cpp
     Look for the LogMessageCallback.singleMessage() with the long
       argument instead of the java.util.Date argument.
     Do not construct a java.util.Date here.
     Pass the apr_time_t to LogMessageCallback.singleMessage().

* src/org/tigris/subversion/javahl/SVNClient.java
     Implement the new singleMessage interface.
     Build a LogMessage using the microseconds time.

* src/org/tigris/subversion/javahl/tests/BasicTests.java
     Test that the new methods that return the time in micro and
       milliseconds compare identically with the java.util.Date.

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Apr 18 01:18:22 2007

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.