Re: [PATCH] libsvn_fs_util: Move functions from err.c file

On Mon, 2007-04-16 at 09:42 -0400, C. Michael Pilato wrote:
> Hey, Bhuvan, I think you can get by with a much shorter log message:

With this change to the log message, Shall I commit this patch?

>
> -----------------------------------------------------------------------
> Move re-usable functions from err.c file in libsvn-fs-fs and
> libsvn-fs-base libraries to fs-util.c file in libsvn-fs-util library.
>
> * subversion/include/private/svn_fs_util.h
> * subversion/libsvn_fs_util/fs-util.c
> (svn_fs__check_fs, svn_fs__err_not_mutable,
> svn_fs__err_not_directory, svn_fs__err_not_file,
> svn_fs__err_no_such_lock, svn_fs__err_lock_expired,
> svn_fs__err_no_user, svn_fs__err_lock_owner_mismatch,
> svn_fs__err_path_already_locked): New functions, the result of a
> merger from similar functions redundantly defined in both FS backend
> modules.
>
> * subversion/libsvn_fs_base/err.c
> * subversion/libsvn_fs_base/err.h
> (svn_fs_base__check_fs, svn_fs_base__err_not_mutable,
> svn_fs_base__err_not_directory, svn_fs_base__err_not_file,
> svn_fs_base__err_no_such_lock, svn_fs_base__err_lock_expired,
> svn_fs_base__err_no_user, svn_fs_base__err_lock_owner_mismatch,
> svn_fs_base__err_path_already_locked): Relocated to (and renamed
> in) svn_fs_util.
>
> * subversion/libsvn_fs_fs/err.c
> * subversion/libsvn_fs_fs/err.h
> (svn_fs_fs__check_fs, svn_fs_fs__err_not_mutable,
> svn_fs_fs__err_not_directory, svn_fs_fs__err_not_file,
> svn_fs_fs__err_no_such_lock, svn_fs_fs__err_lock_expired,
> svn_fs_fs__err_no_user, svn_fs_fs__err_lock_owner_mismatch,
> svn_fs_fs__err_path_already_locked): Relocated to (and renamed
> in) svn_fs_util.
>
> * subversion/libsvn_fs_base/tree.c,
> * subversion/libsvn_fs_base/bdb/locks-table.c,
> * subversion/libsvn_fs_base/bdb/lock-tokens-table.c,
> * subversion/libsvn_fs_base/bdb/rev-table.c,
> * subversion/libsvn_fs_base/uuid.c,
> * subversion/libsvn_fs_base/fs.c,
> * subversion/libsvn_fs_base/revs-txns.c,
> * subversion/libsvn_fs_base/lock.c,
> * subversion/libsvn_fs_fs/tree.c,
> * subversion/libsvn_fs_fs/fs_fs.c,
> * subversion/libsvn_fs_fs/lock.c
> Include new library "private/svn_fs_util.h". Update references to
> relocated (and renamed) error-generation functions.
>
>

-- 
Regards,
Bhuvaneswaran