[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Wrap svn_delta_path_driver_cb_func_t for Python

From: Eric Gillespie <epg_at_pretzelnet.org>
Date: 2007-04-12 23:38:47 CEST

"C. Michael Pilato" <cmpilato@collab.net> writes:

> Looks fine to me. +1 to commit. But maybe go add a test?

I thought about that, but couldn't get a svn.delta.Editor +
svn.delta.make_editor (open_root problem) or svn.delta.editor_t
subclass working. I could provide a test with ra
get_commit_editor, but wouldn't know whether to put it in ra or
delta tests :).

> Eric Gillespie wrote:
> > This seems low impact to me, i'm going to go ahead and commit
> > it. We can always revert if i screw something up ;->
> >=20
> > Eric Gillespie <epg@pretzelnet.org> writes:
> >=20
> >> [[[
> >> Fix Python binding for svn_delta_path_driver_cb_func_t (and therefore
> >> svn.delta.path_driver).
> >>
> >> * subversion/bindings/swig/python/libsvn_swig_py/swigutil_py.c
> >> (svn_swig_py_delta_path_driver_cb_func): New wrapper function.
> >>
> >> * subversion/bindings/swig/python/libsvn_swig_py/swigutil_py.h
> >> (svn_swig_py_delta_path_driver_cb_func): Declare.
> >>
> >> * subversion/bindings/swig/svn_delta.i
> >> (svn_delta_path_driver_cb_func_t): Provide Python typemap, too.
> >> ]]]

--
Eric Gillespie <*> epg@pretzelnet.org

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Apr 12 23:39:56 2007

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.