Daniel Rall wrote:
> On Wed, 11 Apr 2007, Hyrum K. Wright wrote:
>
>> David James wrote:
>>> On 4/11/07, Hyrum K. Wright <hyrum_wright@mail.utexas.edu> wrote:
>>>> This patch improves pool handling within the JavaHL bindings. The key
>>>> idea is to use C++ operator overloading to allow implicit type
>>>> conversion from a Pool object to an apr_pool_t *. This allows usage of
>>>> a Pool object wherever an apr_pool_t * would be expected. This change
>>>> also adds a more OO-esque method of creating and using subpools.
> ...
>>> Did you attach the latest version of your patch? It looks like you
>>> didn't do all the stuff in your patch that your log message says it
>>> did, particularly in Pool.h and Pool.cpp.
>> Ah, included the wrong log message. Updated one attached.
> ...
>> [[[
>> JavaHL: Add implicit type conversion to the C++ Pool class, allowing
>> objects of this class to be directly used wherever a apr_pool_t * is
>> expected.
>>
>> [ in subversion/bindings/javahl/native/ ]
>> * Pool.h,
>> Pool.cpp:
>> (operator apr_pool_t * ): Implicit type conversion to an apr_pool_t *.
>> (clear): New function which wraps svn_pool_clear().
>> (pool): Remove this getter function in favor of the implicit
>> conversion to apr_pool_t *.
>> (m_pool): Rename from this...
>> (pool): ...to this.
>>
>> * SVNAdmin.cpp,
>> Pool.cpp,
>> CopySources.cpp,
>> Outputer.cpp,
>> Path.cpp,
>> SVNClient.cpp,
>> Prompter.cpp,
>> Targets.cpp,
>> Inputer.cpp:
>> Use implicit conversion from Pool to apr_pool_t *.
>> ]]]
>>
>
> Hyrum this patch looks great, +1 to commit.
Done in r24541.
> I did notice a few spots in SVNClient::getContext() where you didn't
> remove the space-before-paren style (which you did do elsewhere). I'm
> in favor of removing it.
Ah. In deference to Karl, I'm attempting to separate the whitespace
changes into separate commits. Ergo, r24542.
-Hyrum
Received on Thu Apr 12 02:55:20 2007