Daniel Rall wrote:
> On Wed, 11 Apr 2007, Mark Phippard wrote:
...
>> Index: subversion/bindings/javahl/src/org/tigris/subversion/javahl/ProplistCallbackImpl.java^M
>> ===================================================================^M
>> --- subversion/bindings/javahl/src/org/tigris/subversion/javahl/ProplistCallbackImpl.java (revision 24532)^M
>> +++ subversion/bindings/javahl/src/org/tigris/subversion/javahl/ProplistCallbackImpl.java (working copy)^M
>> @@ -31,11 +31,16 @@^M
>>
>> public void singlePath(String path, Map props)
>> {
>> - propMap.put(path, props);
>> + propMap.put(normalizePath(path), props);
>> }
>>
>> public Map getProperties(String path)
>> {
>> - return (Map) propMap.get(path);
>> + return (Map) propMap.get(normalizePath(path));
>> }
>> +
>> + private String normalizePath(String path)
>> + {
>> + return path.replace('\\', '/');
>> + }
>> }
>
> We talked this over on IRC. The problem here boils down to the fact
> that svn_proplist_receiver_t is passed a canonical path, rather than a
> path in local style. Erik indicates that this is expected behavior
> for our APIs. Hyrum will be adding a call to svn_path_local_style()
> to JavaHL's C++ code to handle the conversion.
Done in r24536.
> I asked Erik where we document this important API usage fact, but he
> wasn't sure. Do we document this anywhere? If not, I suggest
> documenting it in hacking.html.
Would documenting it in the header files also be useful? After all, it
is something which the API consumers should be aware of. The header
files are what outlines our API specification, and this seems part of
that spec.
-Hyrum
Received on Wed Apr 11 23:16:03 2007