[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Improved JavaHL pool handling

From: David James <james_at_cs.toronto.edu>
Date: 2007-04-11 22:23:33 CEST

On 4/11/07, Hyrum K. Wright <hyrum_wright@mail.utexas.edu> wrote:
> This patch improves pool handling within the JavaHL bindings. The key
> idea is to use C++ operator overloading to allow implicit type
> conversion from a Pool object to an apr_pool_t *. This allows usage of
> a Pool object wherever an apr_pool_t * would be expected. This change
> also adds a more OO-esque method of creating and using subpools.
> This passes all the tests, I just want make this doesn't break things in
> unknown ways.

Hi Hyrum,

Did you attach the latest version of your patch? It looks like you
didn't do all the stuff in your patch that your log message says it
did, particularly in Pool.h and Pool.cpp.

Do you also plan to update the other files in JavaHL to use your new
utility functions (e.g. the destroy and clear functions)? It might be
nice if you did this all in one patch.



> JavaHL: Add implicit type conversion to the C++ Pool class, allowing
> objects of this class to be directly used wherever a apr_pool_t * is
> expected.
> [ in subversion/bindings/javahl/native/ ]
> * Pool.h,
> Pool.cpp:
> (Pool): Add a new constructor, which accepts a parent pool. When Pool
> objects are created this way, they are created as subpools of the
> parent.
> (operator apr_pool_t * ): Implicit type conversion to an apr_pool_t *.
> (clear): New function which wraps svn_pool_clear().
> (pool): Remove this getter function in favor of the implicit
> conversion to apr_pool_t *.
> (m_pool): Rename from this...
> (pool): ...to this.
> * SVNAdmin.cpp,
> Pool.cpp,
> CopySources.cpp,
> Outputer.cpp,
> Path.cpp,
> SVNClient.cpp,
> Prompter.cpp,
> Targets.cpp,
> Inputer.cpp:
> Use implicit conversion from Pool to apr_pool_t *.
> ]]]

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Apr 11 22:23:54 2007

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.