[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] Fix JavaHL testBasicProperties on Windows

From: Mark Phippard <markphip_at_gmail.com>
Date: 2007-04-11 21:06:48 CEST

The JavaHL properties functions were rewritten to use a new callback
API. When that API is called it passes in a path in a format like
C:/folder1/folder2/file.ext. This value is stored as a key in a Map.
When the getProperties method is later called it is passed a String in
the format C:\folder1\folder2\file.ext so it fails to find a value in
the Map.

The attached patch fixes the problem by normalizing the path in the
get and set methods. I am not convinced this is the best solution and
I do not like that we are fixing it in our Impl method as it means
other people that implement the interface have to deal with the same

I also fixed a potential NullPointerError that this test failure revealed.

Mark Phippard

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Received on Wed Apr 11 21:07:10 2007

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.