[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r24515 - trunk/subversion/libsvn_client

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: 2007-04-10 20:31:35 CEST

While working on this:

> Author: cmpilato
> Date: Tue Apr 10 11:27:26 2007
> New Revision: 24515
>
> Log:
> Fix some merge-tracking OBOEs.

I noticed this:

> @@ -1979,7 +1981,8 @@
> continue;
> SVN_ERR(svn_wc__entry_versioned(&child_entry, child_wcpath, adm_access,
> FALSE, pool));
> - child_repos_path = child_wcpath + strlen(merge_cmd_baton->target) + 1;
> + child_repos_path = child_wcpath + \
> + (merge_target_len ? merge_target_len + 1 : 0);
> child_url = svn_path_join(parent_wc_url, child_repos_path, pool);

And said to myself, "Self, should that svn_path_join() also be URI-encoding
the child_repos_path portion? And if so, how many other places in the new
merge tracking code contain similar mistakes?"

Self couldn't answer quickly, but suggested I pose the question to Dan and
the dev-list. So there ya go.

-- 
C. Michael Pilato <cmpilato@collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand

Received on Tue Apr 10 20:31:51 2007

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.