Re: merge-tracking: Intentional reading of merge info outside a BDB transaction?

C. Michael Pilato wrote:
> Okay, that's a violation of the libsvn_fs_base APIs. Here are the rules:
>
> * Use transaction trails where you need them to implement public FS APIs
>
> * Do *NOT* call a public API that uses transaction trails from inside
> another transaction trails.
>
> You're violating the first rule because you aren't transaction-protecting
> your read of the proplist. But the naive fix will cause a violation of the
> second rule.
>
> But I think that latter situation is the real problem. Why in the world do
> we have calls into an FS plugin from the FS_util library?! The util library
> may be called *by* the FS plugins and FS loader, but shouldn't be calling
> *into* either of those things.

Okay, I've fixed this in r24461.

-- 
C. Michael Pilato <cmpilato@collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand