Re: Is mod_dav_svn safe for use in a threaded MPM?

Malcolm Rowe <malcolm-svn-dev@farside.org.uk> writes:

> mod_dav_svn maintains an activity database - a mapping of DAV-generated
> identifiers to Subversion transaction id's. It implements this using
> APR-util's dbm implementation, which may be BDB, gdbm, or one of several
> other dbm-a-like implementations.

This is a simple key-value lookup. It needs nothing fancy at
all. Why not do the simple, obvious thing and have filenames as
keys and file contents as values? I already have a patch to do
just this.

I haven't thought about compatibility, but what about calling the
new database 'activities.d' instead of 'activities'?

> So the upshot of this is that I _think_ we should be serialising our
> apr_dbm_ open/read/close and open/write/close calls in
> mod_dav_svn/activity.c against a per-process mutex. Not doing so means
> that we're relying on the APR dbm implementation to provide thread
> exclusion, which it doesn't appear to do.

Ugh, more complexity, when our needs here are quite simple.

--
Eric Gillespie <*> epg@pretzelnet.org

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Apr 5 18:33:51 2007