Hello,
Please find attached a follow-up patch for r24350. It is based on the
discussion we had in this mailing list thread [1].
[1]
http://subversion.tigris.org/servlets/BrowseList?list=dev&by=thread&from=571463
In this patch, I've moved rest of possible functions from
libsvn_fs_fs/fs.c and libsvn_fs_base/fs.c to libsvn_fs_util/fs-util.c
library. FWIW, i ran 'make davautocheck' with this patch and do not see
any issues.
[[
Move all possible re-usable functions from libsvn_fs_fs/fs.c and
libsvn_fs_base/fs.c to libsvn_fs_util/fs-util.c library.
The list of affected functions are as follows:
base_version() and fs_version() --> svn_fs__version()
check_already_open() and check_already_open() --> check_already_open()
The above functions were static earlier, now they become non-static,
since they are moved to different library.
* subversion/libsvn_fs_base/fs.c
Do not include "svn_version.h", but include the new candidate
"private/svn_fs_util.h" header file.
(check_already_open): Remove.
(base_version): Remove.
Rename base_version function name as svn_fs__version function name in
library_vtable, FS library vtable list which is used by FS loader
library.
(svn_fs_base__init): Rename base_version() function as
svn_fs__version() function.
* subversion/libsvn_fs_fs/fs.c
Do not include "svn_version.h", but include the new candidate
"private/svn_fs_util.h" header file.
(check_already_open): Remove.
(fs_version): Remove.
Rename fs_version function name as svn_fs__version function name in
library_vtable, FS library vtable list which is used by FS loader
library.
(svn_fs_fs__init): Rename fs_version() function as svn_fs__version()
function.
* subversion/include/private/svn_fs_util.h
Declare check_already_open() function to check if the filesystem is
already open.
Declare svn_fs__version() function to return the library version
number.
* subversion/libsvn_fs_util/fs-util.c
Include new dependent header files viz. "svn_fs.h", "svn_version.h",
"svn_private_config.h" and "../libsvn_fs/fs-loader.h".
check_already_open(): New function to check if the filesystem is
already open.
svn_fs__version(): New function to return the library version number.
Patch by: bhuvan
]]
--
Regards,
Bhuvaneswaran
Received on Thu Apr 5 16:22:23 2007