[Patch] ABI Breakage in r22674: svn_client_ctx_t

[Resend from a different account in an attempt to workaround automatic
moderation]

       Hi,
      
Commit r22674 introduced 2 new members in svn_client_ctx_t for subversion
1.5 before existing 1.3 members, which changed the in memory representation
of the binary API.
(New members should only be introduced at the end of this structure before
2.0)

@@ -628,6 +723,15 @@
    * @since New in 1.3. */
   void *log_msg_baton2;
 
+ /** Log message callback function. NULL means that Subversion
+ * should try @c log_msg_func2, then @c log_msg_func.
+ * @since New in 1.5. */
+ svn_client_get_commit_log3_t log_msg_func3;
+
+ /** The callback baton for @c log_msg_func3.
+ * @since New in 1.5. */
+ void *log_msg_baton3;
+
   /** Notification callback for network progress information.
    * May be NULL if not used.
    * @since New in 1.3. */

The attached patch fixes the issue by moving the members

[[[
Fixed structure layout of svn_client_ctx_t (ABI breakage)

* subversion/include/svn_client.h
  (svn_client_ctx_t): moved log_msg_func3 and log_msg_baton3
   within structure to be compatible with 1.4 and 1.3.

Patch by: Bert Huijben <bhuijben@competence.biz>
]]]

        Bert

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org